search

pypdfium2-team / ctypesgen

Wrapper generator for Python ctypes
BSD 2-Clause "Simplified" License
1 stars 0 forks source link

Attempt to revise logging #14

Closed mara004 closed 4 months ago

mara004 commented 4 months ago

Hmm, it's shorter, but doesn't really make anything better.

The custom functions & error classes might actually be useful to filter things (although they currently don't do anything special, and error classes appear to be completely unused. Further, message labels are not used consistently).

Also I'm afraid of possibly having overlooked something that relied on errors/warnings to be tuples of (message, cls) and not just the message.

Closing for now given these reasons.

mara004 commented 4 months ago

It's still debatable, though. One could argue that it's essentially unused ballast that burdens the codebase, given the low significance of message filtering etc. (it does not impact the actual outcome)