pypdfium2-team / pypdfium2

Python bindings to PDFium
https://pypdfium2.readthedocs.io/
349 stars 15 forks source link

Conda packaging (WIP) #268

Closed mara004 closed 10 months ago

mara004 commented 10 months ago

Another consideration regarding the pdfium-binaries pin in pypdfium2_raw, which I'd like to record but not add as code comment due to the low significance:

One could think about allowing lower versions if headers did not change.
While this should be ABI-safe, the problem is that it'd render the version file invalid,
and pdfium does not embed version into binaries, so it's hard to determine dynamically.
Also, the benefit would be quite low since we probably can't programatically distinguish
additions and changes to pdfium's public API. (And even if we could, it would require
hasattr-guards to support older versions that lack new symbols, which is not very nice.)
mara004 commented 10 months ago

I believe the packaging code is basically ready to be merged. CI's not done yet but we could do that in a follow-up PR.

mara004 commented 10 months ago

Hi @adam-huganir (and @mkroutikov, @YinlinHu if interested),

as you can see, I'm planning to put pypdfium2 on anaconda. Would you please create an account at anaconda.org (and send me the name) so I can add you to the contributors?

Thanks!

adam-huganir commented 10 months ago

Doneso, under adam@huganir.com

mara004 commented 10 months ago

Thanks; unfortunately it looks like I can't add members by mail address. Would you please tell me the public user name instead? You might have to set that up under Settings -> Public Profile first.

mara004 commented 10 months ago

^ ping @adam-huganir just in case you didn't get notified for the previous message no stress though, take your time :)

adam-huganir commented 10 months ago

^ ping @adam-huganir just in case you didn't get notified for the previous message no stress though, take your time :)

oops used the wrong anaconda site, I am adam-huganir on the .org one now

mara004 commented 10 months ago

Added, thanks!