Odds and Ends - Githubissues

pypeit / PypeIt-development-suite

8 stars 11 forks source link

Odds and Ends #151

Closed profxj closed 3 years ago

profxj commented 3 years ago

This is the companion to PR #1181 in the main repo (already merged).

I see it also includes the files for PR #1175 too.

profxj commented 3 years ago

Cooked v1.4.3 goes with this PR.

finagle29 commented 3 years ago

I think the hardcoded spec1d and sensfunc files in build_ql_masters need to have the filenames changed to the new naming convention (i.e. change 2019Nov18T104704 to 20191118T104704) because when I tried to run the dev suite tests for pypeit/PypeIt#1192, the MOSFIRE ql test failed because the std spec1d and sensfunc files weren't moved over from REDUX_OUT in build_ql_masters

finagle29 commented 3 years ago

I just pushed a commit to address my last comment so looks good to me!

finagle29 commented 3 years ago

merging