search

pypeit / PypeIt-development-suite

8 stars 11 forks source link

coadd2d files #205

Closed debora-pe closed 2 years ago

debora-pe commented 2 years ago

Added example of coadd2d. The cases tested are:

offset is a list and weights = uniform --> vlt_xshooter_vis_manual

offsets = maskdef_offsets and weights is a list --> keck_mosfire_long2pos1_h

offsets = auto and weights = auto -->keck_lris_blue_multi_600_4000_d560

offsets = maskdef_offsets and weights = auto and user_obj provided (multislit) --> keck_deimos_830g_m_9000_dither

offsets = auto and weights = auto and user_obj provided (echelle) --> gemini_gnirs_32_sb_sxd

profxj commented 2 years ago

@jhennawi -- isn't the Coadd2D PR already merged into develop? If so, we should merge this is now too.

jhennawi commented 2 years ago

Yes it is @profxj, but I don't think we want to re-run tests on objfind refactor since those just passed. My suggestion is that we merge objfind_refactor into develop, and then run the dev suite once on develop (with this PR merged) before we tag and merge into release.