search

pypeit / PypeIt-development-suite

8 stars 11 forks source link

MOSFIRE calibration and combination association #214

Closed debora-pe closed 2 years ago

debora-pe commented 2 years ago

Added unit test.

Companion to: https://github.com/pypeit/PypeIt/pull/1445

debora-pe commented 2 years ago

Great! Either here or in the main repo, it would also be great to have some unit tests that specifically test the behavior for the different dither combinations that can be parsed by get_comb_group in keck_mosfire.py. I think you catch one instance of that here, but is it possible to catch all of them?

@kbwestfall I added 2 more datasets in this same unit test. In this case it will test in total 4 dither sequences. It's not all of them, but most of them. This is all we have in the Dev Suite and I did not wanted to add more data.

kbwestfall commented 2 years ago

Great! Either here or in the main repo, it would also be great to have some unit tests that specifically test the behavior for the different dither combinations that can be parsed by get_comb_group in keck_mosfire.py. I think you catch one instance of that here, but is it possible to catch all of them?

@kbwestfall I added 2 more datasets in this same unit test. In this case it will test in total 4 dither sequences. It's not all of them, but most of them. This is all we have in the Dev Suite and I did not wanted to add more data.

Thanks, @deborape !