search

pypeit / PypeIt-development-suite

8 stars 11 forks source link

WHT_ISIS test suite has serious problems #41

Closed jhennawi closed 8 months ago

jhennawi commented 6 years ago

Sky subtracted frame looks messed up. I suspect the wavelengths are busted. Can someone please investigate, @profxj?

rcooke-ast commented 6 years ago

@jhennawi raised the following issue in PypeIt, which has been translated here:

WHT_ISIS_blue is producing complete garbage in the test suite. I've tracked down the problem to the MasterFlat which has nonsense values. I'm not sure what is causing this issue in the flat field code, but it leads to crashes because the data is completely garbage after being divided by this image.

We need to either fix this issue or remove this from the dev suite. @rcooke-ast would you mind taking a look at what causes the flat fielding code to go berserk?

P.S. Image r2324580.fit.gz is saturated and should be removed from the dev suite and the pypit file. It would be good idea to vet images for problems before putting them in the dev suite. Note however that this issue is not the source of the problem, since I get garbage even when excluding it.