scale_in_filter in flux calibration has some issues that need to be fixed

pypeit / PypeIt

The Python Spectroscopic Data Reduction Pipeline

BSD 3-Clause "New" or "Revised" License

160 stars 103 forks source link

scale_in_filter in flux calibration has some issues that need to be fixed #1106

Open jhennawi opened 3 years ago

jhennawi commented 3 years ago

Are the filter curves in vacuum or air? There should be a README file explaining this. I am not convinced that the math is correct here for non-uniform wavelength sampling, but it may be a small effect.

Also, should we switch to use this package?

https://speclite.readthedocs.io/en/latest/api.html#module-speclite.filters

profxj commented 3 years ago

@feigewang -- please comment

feigewang commented 3 years ago

I suppose the filter curves are in air not vacuum but I could be wrong. I am fine with switching to the speclite package.