pypeit / PypeIt

The Python Spectroscopic Data Reduction Pipeline
BSD 3-Clause "New" or "Revised" License
164 stars 105 forks source link

Separate illumflat is not made if pixelflat already exists (when `run_pypeit` is executed with the `-c` argument). #1662

Closed rcooke-ast closed 1 year ago

rcooke-ast commented 1 year ago

run_pypeit with the -c option appears to ignore the BPM. This was tested with the keck_kcwi/medium_bl data.

rcooke-ast commented 1 year ago

This is actually an issue to do with the pixelflat being generated first, and then a separate illumflat is trying to be generated and merged into the pixelflat.

rcooke-ast commented 1 year ago

Also, in this case, the BPM doesn't work, because the dataset has multiple different BPM, but only 1 BPM is actually used (the one not relevant to the Science frame).

rcooke-ast commented 1 year ago

Addressed by PR #1663