search

pypeit / PypeIt

The Python Spectroscopic Data Reduction Pipeline
BSD 3-Clause "New" or "Revised" License
161 stars 104 forks source link

Improved scattered light model #1684

Closed rcooke-ast closed 10 months ago

rcooke-ast commented 1 year ago

At the moment a very crude model of the scattered light is implemented, and this is only used for KCWI reductions. Ideally, we should use the inter-order regions (for Echelle reductions) and the interslice region for SlicerIFU reductions. This enhancement would require that we pass the Slits calibration files into rawimage.py (because the scattered light should be removed before the flatfielding frames), and this is not currently well setup for this.

The current simplistic model for scattered light subtraction (at least for KCWI) was implemented in PR #1661. I assign myself to look into a better model for KCWI. Part of this effort should involve using the Slits information.

kbwestfall commented 10 months ago

Partially addressed by #1704 . @rcooke-ast , can you comment on what's left to do?

rcooke-ast commented 10 months ago

Yes, this is now "fully" addressed. KCRM is not implemented, but KCWI and ESI are both implemented. So, this can be closed.