pypeit / PypeIt

The Python Spectroscopic Data Reduction Pipeline
BSD 3-Clause "New" or "Revised" License
160 stars 102 forks source link

Adds support for `numpy>=2.0.0` #1829

Closed kbwestfall closed 2 months ago

kbwestfall commented 2 months ago

Accommodates changes in numpy version 2.0.

According to this, these changes should not affect use by numpy <2.0.0, so I haven't included an increment in the dependency version requirements yet. But we should likely warn users to be aware of this change and encourage them to upgrade numpy once this is released.

I'll re-run the dev-suite on this and post the results, but we should expect some bok_bc failures that we need to fix before tagging a new release.

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 48.96332% with 320 lines in your changes missing coverage. Please review.

Project coverage is 38.48%. Comparing base (8ec2351) to head (304d424). Report is 87 commits behind head on develop.

Files Patch % Lines
pypeit/scripts/cache_github_data.py 1.78% 55 Missing :warning:
pypeit/cache.py 66.41% 44 Missing :warning:
pypeit/scripts/clean_cache.py 13.33% 39 Missing :warning:
pypeit/core/wavecal/templates.py 0.00% 21 Missing :warning:
pypeit/pypeitdata.py 79.06% 18 Missing :warning:
pypeit/utils.py 55.00% 18 Missing :warning:
pypeit/core/flux_calib.py 51.85% 13 Missing :warning:
pypeit/io.py 50.00% 10 Missing :warning:
pypeit/scripts/install_extinctfile.py 9.09% 10 Missing :warning:
pypeit/scripts/install_linelist.py 9.09% 10 Missing :warning:
... and 37 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1829 +/- ## =========================================== - Coverage 38.53% 38.48% -0.05% =========================================== Files 206 207 +1 Lines 47992 48151 +159 =========================================== + Hits 18494 18532 +38 - Misses 29498 29619 +121 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

kbwestfall commented 2 months ago

Tests pass, except for the one expected failure.

Test Summary
--------------------------------------------------------
--- PYTEST PYPEIT UNIT TESTS PASSED  256 passed, 6720 warnings in 510.85s (0:08:30) ---
--- PYTEST UNIT TESTS PASSED  148 passed, 2653 warnings in 916.53s (0:15:16) ---
--- PYTEST VET TESTS PASSED  61 passed, 105975 warnings in 5540.82s (1:32:20) ---
--- PYPEIT DEVELOPMENT SUITE FAILED 1/239 TESTS  ---
Failed tests:
    bok_bc/600 pypeit
Skipped tests:
Testing Started at 2024-07-16T18:18:46.734145
Testing Completed at 2024-07-17T13:49:03.433300
Total Time: 19:30:16.699155

Merging!