Closed kbwestfall closed 2 months ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Attention: Patch coverage is 48.96332%
with 320 lines
in your changes missing coverage. Please review.
Project coverage is 38.48%. Comparing base (
8ec2351
) to head (304d424
). Report is 87 commits behind head on develop.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Tests pass, except for the one expected failure.
Test Summary
--------------------------------------------------------
--- PYTEST PYPEIT UNIT TESTS PASSED 256 passed, 6720 warnings in 510.85s (0:08:30) ---
--- PYTEST UNIT TESTS PASSED 148 passed, 2653 warnings in 916.53s (0:15:16) ---
--- PYTEST VET TESTS PASSED 61 passed, 105975 warnings in 5540.82s (1:32:20) ---
--- PYPEIT DEVELOPMENT SUITE FAILED 1/239 TESTS ---
Failed tests:
bok_bc/600 pypeit
Skipped tests:
Testing Started at 2024-07-16T18:18:46.734145
Testing Completed at 2024-07-17T13:49:03.433300
Total Time: 19:30:16.699155
Merging!
Accommodates changes in numpy version 2.0.
According to this, these changes should not affect use by numpy <2.0.0, so I haven't included an increment in the dependency version requirements yet. But we should likely warn users to be aware of this change and encourage them to upgrade numpy once this is released.
I'll re-run the dev-suite on this and post the results, but we should expect some
bok_bc
failures that we need to fix before tagging a new release.