search

pypeit / PypeIt

The Python Spectroscopic Data Reduction Pipeline
BSD 3-Clause "New" or "Revised" License
160 stars 102 forks source link

HOTFIX to SlitTraceBitMask #1848

Closed debora-pe closed 3 weeks ago

debora-pe commented 1 month ago

This is an hotfix to SlitTraceBitMask but was causing the spatial flexure process to not being able to find the shift.

I'll still run the tests to make sure that the problem is fixed in every dataset.

Hopefully, this resolves issue #1843

codecov-commenter commented 1 month ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 38.03%. Comparing base (bd77c38) to head (2739521).

Files with missing lines Patch % Lines
pypeit/slittrace.py 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #1848 +/- ## ======================================== Coverage 38.03% 38.03% ======================================== Files 211 211 Lines 48975 48975 ======================================== + Hits 18626 18627 +1 + Misses 30349 30348 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

debora-pe commented 3 weeks ago

Thanks for the reviews. Unfortunately this fixed only one cause of the failed spatial flexure. I'm working on improving the spatial flexure calculation, but I'll have another PR for that. I am merging this for now.