generate_sensfunc should operate on an astropy table not a python std_obj.

[jhennawi]

https://github.com/PYPIT/PYPIT/blob/24b39b0e93d7921885a448ece7954184f7fb8a98/pypit/core/arflux.py#L434

generate_sensfunc is a core routine that should not require any objects as input. If you look at the code the std_obj definition is totally superfluous. It should just operates on tags in an astropy table.

If someone wants to use this code they either need to figure out how to instantiate these objects, or write a class that looks like what this routine needs. I don't see the point of that. Why not just operate on an astropy Table?

I might be missing the point of the SpecObjExp class, but I don't see why this thing is not just an astropy table. The methods attached to this class appear to be rather trivial and unnecessary, but maybe I'm missing something.

[profxj]

I think a Table would be unnecessary here. How about you refactor it to just take: wave, counts, var as ndarray's?

[jhennawi]

Sounds good will do that.

[profxj]

is this done @jhennawi ?

[EmAstro]

Hi X, I'll submitt a PR on this later this week.

On Saturday, 25 August 2018, J. Xavier Prochaska notifications@github.com wrote:

is this done @jhennawi ?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.< https://ci6.googleusercontent.com/proxy/fliqaRCynaUcT68Pcc1JFTfr7LSeWXKeHVTO2noDqbDaupybau4FTXDJTxNxnLgqj0Mk_SDkOc9PtcnEoIGiPU506L9FXgIcySDFVKOnso0hs58IQH_L4Ux0Y3xt6gi4USu_Ovv9wErdKL-QItggA4oZCE9rxA=s0-d-e1-ft#https://github.com/notifications/beacon/AdCDLaNQPWvc2U0J_P4sxlGZnnVV4wHMks5uUV7igaJpZM4UYwPt.gif

--

Emanuele Paolo Farina

PostDoc in Astronomy & Astrophysics @ University of California, Santa Barbara Department of Physics Broida Hall, UC Santa Barbara Santa Barbara, CA 93106-9530 [USA]

E-Mail: emanuele.paolo.farina@gmail.com Skype: pennellone20 Home Page: https://emastro.github.io/index.html

[EmAstro]

Done!