(feat) added get_phi_vector_noise_obs() method

pypest / pyemu

python modules for model-independent uncertainty analyses, data-worth analyses, and interfacing with PEST(++)

BSD 3-Clause "New" or "Revised" License

169 stars 94 forks source link

(feat) added get_phi_vector_noise_obs() method #446

Closed mnfienen closed 10 months ago

mnfienen commented 11 months ago

for ObservationEnsemble and a test. There is a test in there as well. Have a look.

mnfienen commented 11 months ago

@briochh and @jtwhite79 - I requested a review from Brioch since we were talking about it in an issue. Hopefully all good.

coveralls commented 11 months ago

coverage: 79.794% (+0.05%) from 79.747% when pulling 230f8c22e77ce6910419186631e3e16dae194d64 on mnfienen:feat_ens_phi into a026d1821b18a8f9f854dea2c04dc059aab09c0c on pypest:develop.

mnfienen commented 11 months ago

Please don't merge yet - I'm working on some refactoring

briochh commented 11 months ago

did you want to add more to this @mnfienen?

mnfienen commented 10 months ago

hey @briochh - I've been away for the month so missed this. I'm tempted to fold it in and experiment with the other option later unless you have time to test it?

briochh commented 10 months ago

Welcome back @mnfienen . Yeah go for the merge. We can look into testing some improves later from dev branch.

mnfienen commented 10 months ago

Right on @briochh - merging