search

pypest / pyemu

python modules for model-independent uncertainty analyses, data-worth analyses, and interfacing with PEST(++)
BSD 3-Clause "New" or "Revised" License
174 stars 95 forks source link

feat(get-pestpp): add get-pestpp command line interface #457

Closed jdhughes-usgs closed 1 year ago

coveralls commented 1 year ago

Coverage Status

coverage: 77.803% (-2.0%) from 79.841% when pulling f942bdd635ca2708ca70dbdee1ebcb6c4d660a25 on jdhughes-usgs:get-pestpp-cli into 0aa1985fcc4cc9914e19f56fdcc1757e05526fbe on pypest:develop.

briochh commented 1 year ago

@jdhughes-usgs just noting this in here. Looks like the failing tests are related to pandas 2.1 update and pd.read_csv() with delim_whitespace. Looks unrelated to your PR.

jdhughes-usgs commented 1 year ago

@briochh There were three columns in one line of one example dataset that was causing the pandas problem. Let me know if this is not a valid fix.

briochh commented 1 year ago

@jdhughes-usgs, yeah but I think that the "extra" column was split by a comma. @jtwhite79, might be able to comment on whether the comma is valid in there, think it has always been there. Looks like the delim_whitespace=True option now still splits on ,, which is a bit weird.

Man, spending a lot of time chasing breaking changes these days!

jdhughes-usgs commented 1 year ago

@jdhughes-usgs, yeah but I think that the "extra" column was split by a comma. @jtwhite79, might be able to comment on whether the comma is valid in there, think it has always been there. Looks like the delim_whitespace=True option now still splits on ,, which is a bit weird.

Man, spending a lot of time chasing breaking changes these days!

@briochh It was split by a comma. It was the only line with an extra comma. Hopefully @jtwhite79 can let me know what needs to be done.

briochh commented 1 year ago

@jdhughes-usgs pin pandas? https://github.com/pandas-dev/pandas/issues/54918

jdhughes-usgs commented 1 year ago

@briochh could do that but could be something that bites later on.