Change bind names without trailing underscore?

pypest / pypestutils

python-wrapped PEST utilities #winning

The Unlicense

11 stars 6 forks source link

Change bind names without trailing underscore? #2

Closed mwtoews closed 1 year ago

mwtoews commented 1 year ago

I've looked far and wide, and I don't see any strong reason why (e.g.) install_mf6_grid_from_file needs to be binded to install_mf6_grid_from_file_ (with a trailing underscore). This is was just a gfortran name mangling convention that we don't need to do.

Could I change these to simple bind names that match the Fortran function names? If so, I can make these changes throughout, but just checking before I do.

jtwhite79 commented 1 year ago

Sure Mike. As long as we can get consistent exported names in the lib across platforms and compilers, I'm good...

mwtoews commented 1 year ago

Cool, done with 2ea1627dda739e8d18b0e7f4c10296fd224ca4b8

I've also added (e.g.) !DIR$ ATTRIBUTES DLLEXPORT :: inquire_modflow_binary_file_specs which is a similar bind mechanism for Intel compilers on Windows. This is done with mf6bmi too.