search

pypi / legacy

This PyPI is no more! See https://github.com/pypa/warehouse.
Other
61 stars 46 forks source link

redirect loops are generated on package rename #158

Closed ewdurbin closed 8 years ago

ewdurbin commented 10 years ago

Originally reported by: Doug Wiegley (Bitbucket: dougwig, GitHub: dougwig)

(issue hijacked from Doug's report)

The issue arises when the new name is the same as the old name when normalized.

For example, acos_client -> acos-client.

ewdurbin commented 10 years ago

Original comment by Donald Stufft (Bitbucket: dstufft, GitHub: dstufft):

This should no longer be able to happen. PyPI now normalizes the simple page (e.g. "Django" is hosted at /simple/django/). This means that the URL will remain consistent between renames that don't change what the "normalized" form is and thus the redirects will also remain consistent and we won't end up in this redirect loop.

ewdurbin commented 10 years ago

Original comment by Jonathan Ultis (Bitbucket: jultis, GitHub: Unknown):

It's now happening to instant-rst. Bandersnatch mirroring suffers.

https://pypi.python.org/simple/instant-rst/

ewdurbin commented 10 years ago

Original comment by Anton Backer (Bitbucket: staticshock, GitHub: staticshock):

This is happening to the colored-traceback package right now, for the same reason. How does it stay in the cache before expiration?

ewdurbin commented 10 years ago

Original comment by ewdurbin (Bitbucket: ewdurbin, GitHub: ewdurbin):

This has resolved by cache expiration. I think we may need to be a bit more clever in our handling of package renames.