pypi / warehouse

The Python Package Index
https://pypi.org
Apache License 2.0
3.58k stars 961 forks source link

Verify GitLab pages URLs #16753

Open wangenau opened 1 week ago

wangenau commented 1 week ago

What's the problem this feature will solve? After playing around with the new verified sections through trusted publishing, I noticed that GitLab pages will not be marked as verified. According to the documentation, this is the case for GitHub, but not GitLab: https://docs.pypi.org/project_metadata/#verified-details Since documentations are often uploaded to GitLab pages, this will create an unpleasant split between verified details (i.e., the repository URL) and unverified URLs (i.e., the documentation URL).

Describe the solution you'd like Similar to GitHub, the GitLab pages should get verified as well. Similar to the documentation, these would need to be added:

di commented 1 week ago

I think we can do something similar to what we do for GitHub here: https://github.com/pypi/warehouse/blob/c979275c04515db5b3efeac907a71fffe9701bf8/warehouse/oidc/models/github.py#L342-L379