Closed woodruffw closed 3 days ago
To summarize: this makes it easier to enable attestations from other TP providers, since they no longer need to update multiple independent sites: each new attestation source only needs to add attestation_identity
to its base mixin.
NB: This also removes our top-level dependency on sigstore
, since all ops go through pypi_attestations
(which still uses sigstore
itself, of course). I can remove that in this PR or a follow-on.
NB: This also removes our top-level dependency on sigstore, since all ops go through pypi_attestations (which still uses sigstore itself, of course). I can remove that in this PR or a follow-on.
Let's go ahead and do it here, thanks!
This removes some usage of stubs in favor of real models (via factories) where possible, and eliminates some potential sources of double-state/divergence in the original services.
In particular:
OIDCPublisherMixin.supports_attestations
is nowattestation_identity
, and returns aPublisher | None
that can be used directly for verificationOIDCPublisherMixin.publisher_verification_policy
is removed, since thePublisher
now encodes the verification policy_publisher_from_oidc_publisher
is removed, sinceattestation_identity
serves the same purpose