pypi / warehouse

The Python Package Index
https://pypi.org
Apache License 2.0
3.51k stars 945 forks source link

Design feedback #2417

Closed Safihre closed 6 years ago

Safihre commented 6 years ago

Forgive me if I missed the appropriate place to report feedback on the new UI, can I do it here?

I enjoy the new style but would have some feedback, specifically on the project-pages. While it is very nice that they now scale to any device, the main device will still be a desktop computer since this is where you run pip. So with that in mind, here's some things I wanted to note:

  1. On a regular 1080p screen, the header is currently very large and covers more than half of the screen before getting to the actual description of the project. I understand that this is partly due to the preproduction-warning and the donate bar. So overall I would suggest to have a close (X) option for the preproduction-warning (via localStorage?) and reduce the overall height of the header by reducing padding and potentially different placement of the donate bar.
  2. I like the pip install xx in the header, but because of the background color it doesn't really stand out and is easy to miss. I would suggest a more contrasting color?
  3. The tag-line does not really stand out, where in current pypi it's the first thing you read under a project title. I would suggest to either give the text more contrast, or move it to the central part of the screen? So in the right column, in the same style as 'Navigation' for example.
  4. Overall on desktops the padding on buttons and other things in the left bar can be reduced a bit I think, there is a lot of spacing especially in the left project-bar which makes it very long, particularly on smaller projects (like mine).
  5. Small one: on my project it now randomly says 'About 5 hours ago', I think it needs a 'Last modified' text.
  6. I assume it's still coming, but when I am logged in I don't see any extra buttons on my project pages. I would expect for example to see an Edit files option?

I know CSS/HTML/JS so I could submit PR's for this, but I didn't want to be an unwelcome guest! 👻

dstufft commented 6 years ago

Assigning this to @nlhkabu since she is in charge of the design :)

sersorrel commented 6 years ago

1988 ("Create 'condensed' design version") is relevant to this.

compute-e commented 6 years ago

The current older version has a mainly grey and white colour scheme, a different layout and less whitespace. Some things that can be improved with the layout/design of the newer version:

The topics of my improvement suggestions: reducing whitespace, the colour scheme, moving the project tagline to the main column and organising the sidebar into a better structure, with fewer sections.

Newer design that needs some improvements Older design which had parts that look better
screenshot_2017-11-16-17-40-21_kindlephoto-51496782 screenshot_2017-11-16-17-40-56_kindlephoto-51571735

Even though the new design looks okay shown here in portrait orientation, the whitespace and other things look worse in the horizontal screen size on my tablet device.

Safihre commented 6 years ago

Is it me, or has this project stalled? There are so few commits that are not pyup-bot. I would enjoy making the suggested changes and submitting a PR, but it seems it might be weeks before anyone would look at it or for it to get merged. What is the timeline for warehouse to take over? @dstufft @anowlcalledjosh @nlhkabu

compute-e commented 6 years ago

I don't know much (only recently found out about this pre-production next generation PyPi version)
but the Github project has 146 issues and 22 pull requests so maybe progress is slow. They probably have many bugs and suggestions to check - hopefully you'll get a reply from the Warehouse team. Thanks for noticing my ideas.

dstufft commented 6 years ago

It has not stalled, there has just been more behind the scenes work going on currently.

brainwane commented 6 years ago

@Safihre Thanks for your note and sorry for the slow response!

The folks working on Warehouse have just gotten funding to concentrate on improving and deploying Warehouse, and will in December kick off work towards the first milestone: redirecting pypi.python.org to pypi.org. We (especially @nlhkabu) will have more responses to your and @user-e's feedback after that kickoff.

Thanks again.

Safihre commented 6 years ago

@brainwane Awesome! Still my initial question remains: are PR's from regular folk like us appreciated? Or rather keep bigger UI changes within the team?

brainwane commented 6 years ago

@Safihre Thanks for the suggestion and the discussion!

I'm sorry for the delay in response here. The folks working on Warehouse have gotten limited funding to concentrate on improving and deploying Warehouse, and have kicked off work towards our development roadmap -- the most urgent task is to improve Warehouse to the point where we can redirect pypi.python.org to pypi.org so the site is more sustainable and reliable. Along the way we've been trying to reply to issues that need replies -- I missed getting to this earlier and I'm sorry about that.

Nicole (@nlhkabu) has written up her design goals, including her assessment of the legacy UI and its problems, at http://whoisnicoleharris.com/2015/12/31/designing-warehouse-an-overview.html . She's doing some user tests to get more data on what users have trouble with, and during those tests, asking about design inconsistency between www.python.org, and usual device/browser/display usage and usual size/resolution.

We absolutely welcome pull requests from everybody, but for larger design changes it would probably be best to talk about them first in issues or on the mailing list, as we've done here, rather than start with PRs. (Design discussion can get tetchy when people talk past each other, so even though everyone's been friendly so far, I figured I'd link to the CoC and some general design feedback tips from Wikimedia.)

Now that the team is well underway, we'll be faster at responding to new issues and comments -- sorry again for the wait.

Safihre commented 6 years ago

Thanks for that response, the increase in activity here is great. I was actually hoping for a response of @nlhkabu on mine and @user-e's issues? Her blog post and your post here seem to indicate we should provide constructive feedback on Github, which is exactly what we did.. Yet no response so far.

brainwane commented 6 years ago

@Safihre I'm sorry - you're getting a response from me at the moment but I've been in frequent consultation with Nicole. She's taking your concerns into account, gathering data via user tests, and then using that data to figure out how to proceed and what to prioritize.

I think part of the issue with this particular thread (#2417) is that we were trying to talk about a lot of things at once. :) Some of your concerns we have already addressed, or we're addressing in other issues:

Dividing up your individual remaining suggestions into different issues would be useful, so I'm going to do that:

Let's make a fresh start. I'm going to close this issue now, but please open new issues for particular concerns you have about Warehouse design & functionality! We do welcome your feedback and I'm sorry for the bumps along the way here.