pypingou / fedora-owner-change

Small tool to report the latest ownership change in the Fedora package database.
2 stars 2 forks source link

publish dead.package contents for retired packages #2

Open tyll opened 11 years ago

tyll commented 11 years ago

Please include the contents of the dead.package for the respective branch of retired packages to make it easy to spot where this was missed.

pypingou commented 11 years ago

At the moment the only source of information is datagrepper which queries messages of fedmsg.

I don't believe fedmsg publishes information from the dead.package, so it would imply having a way to get it, either http request against pkgs.fp.o or cloning the git repo. I might consider the first approach, the second makes me really uncomfortable.

ralphbean commented 11 years ago

You could probably construct a URL in constant time to something like this: http://pkgs.fedoraproject.org/cgit/geoip-geolite.git/tree/dead.package

If those links were present in the report, would that suffice?

tyll commented 11 years ago

On Mon, Sep 23, 2013 at 02:11:49PM -0700, Ralph Bean wrote:

You could probably construct a URL in constant time to something like this: http://pkgs.fedoraproject.org/cgit/geoip-geolite.git/tree/dead.package

If those links were present in the report, would that suffice?

Actually I would prefer to get the actual contents (it is also the only place where one might find a reason for the retirement). I am thinking about code like the following:

def get_dead_package(package, branch):
    git_map = {"devel": "master",
           "F-20": "f20",
           "F-19": "f19",
           }
    git_branch = git_map[branch]
    dead_url = \
        'http://pkgs.fedoraproject.org/cgit/{0}.git/plain/'\
        'dead.package?h={1}'.format(package, git_branch)
    dead = requests.get(dead_url).text
    dead = dead.strip()

And then maybe a call for each branch and a check whether the dead.package files differ. I can take a look into providing a patch, if you would integrate it. A different possibility would be to enhance the fedmsg git topics with a special topic about whether a dead.package file was added or removed to a branch. Currently there is only the generic receive notification.

pypingou commented 11 years ago

I would be fine with getting the content of dead.package in devel (and would accept the patch), I'm less fan of checking every branches.