search

pyplati / platipy

Processing Library and Analysis Toolkit for Medical Imaging in Python
https://pyplati.github.io/platipy/
Apache License 2.0
111 stars 27 forks source link

Added in a utilisation test #122

Closed SimonBiggs closed 2 years ago

SimonBiggs commented 2 years ago

Hi @pchlap and @rnfinnegan,

I wanted to reproduce the error over at https://github.com/pyplati/platipy/issues/121 within a pytest test. Here is that attempt. I wasn't able to reproduce the error locally however. So... up to you if you think this test is helpful or not :slightly_smiling_face:.

Cheers, Simon

SimonBiggs commented 2 years ago

It seems like the issue ended up being a bug in the user's code?

Yup, that's the case

So happy to have our first contribution to platipy outside of Rob and me.

Glad to be able to be the first outside contributor :)

Useful to have an additional test

Yeah, I thought there might be value to have it in there anyway.

SimonBiggs commented 2 years ago

Oops, my bad with that plt import. I need to move the matplotlib import to the top. I'm in Sydney this week. I'd be more than happy @pchlap if you jumped in and made that change as I won't be able to get to it until next week.

pchlap commented 2 years ago

Oops, my bad with that plt import. I need to move the matplotlib import to the top. I'm in Sydney this week. I'd be more than happy @pchlap if you jumped in and made that change as I won't be able to get to it until next week.

Yep happy too. I'm always a bit unsure on how to best collaborate on a PR coming from a fork. Since I can't write to your fork... Do I just start a fresh PR?

SimonBiggs commented 2 years ago

Ideally, I'd set the following permission and let you edit the commits:

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

But, because I made the PR from an organisation account I don't believe I have the option to do that. What I'll do, is I'll directly give you commit access to my fork. Then you'll be free to just directly make changes.

SimonBiggs commented 2 years ago

Kk, I've given you commit access to my fork. Let me know if that lets you make changes.

pchlap commented 2 years ago

Kk, I've given you commit access to my fork. Let me know if that lets you make changes.

Thanks @SimonBiggs, that works well :)

pchlap commented 2 years ago

Thanks a lot for this @SimonBiggs. I will merge it through.