search

pyplati / platipy

Processing Library and Analysis Toolkit for Medical Imaging in Python
https://pyplati.github.io/platipy/
Apache License 2.0
103 stars 24 forks source link

Fix issue when ROI is completely missing from ROIContourSequence #143

Closed pchlap closed 1 year ago

pchlap commented 2 years ago

Hi @rnfinnegan,

I found a bug in the rtstruct conversion script when converting RTSTRUCT files exported from RayStation. Mostly they work fine but it seems when a structure is empty there, they omit it from the ROIContourSequence list entirely. So this PR just corrects that logic making sure the correct structure is mapped from StructureSetROISequence to the item in ROIContourSequence.

@dalmouiee I thought I'd tag you for a review here too? This one is closely related to what we do in pydicer anyway (in fact this issue arose while running through pydicer). But I was also thinking with Rob taking up a new role it would be great if you'd be interested in getting a bit more involved with platipy. Even if it's just the occasional code review. Up to you though :)

dalmouiee commented 2 years ago

Hey @pchlap, I'm definitely interested thanks for the tag! For sure tag me in future reviews and hopefully anything that arises from my usage of pydicer that relates to platipy I'll report and work on for sure :)