search

pyplati / platipy

Processing Library and Analysis Toolkit for Medical Imaging in Python
https://pyplati.github.io/platipy/
Apache License 2.0
103 stars 24 forks source link

numpy >1.18 has no np.alen() #164

Closed nis closed 1 year ago

nis commented 1 year ago

It's used here: https://github.com/pyplati/platipy/blob/4814826b0a3cd8e6a4eebc549c0122bcbbdc37a8/platipy/dicom/io/crawl.py#L592

len(...) can be used instead of np.alen(...), but I'm unsure how backwards compatible it is.

np.alen(...) was depreceated in 1.18: https://numpy.org/devdocs/release/1.18.0-notes.html#deprecate-np-alen

pchlap commented 1 year ago

Thanks for the bug report @nis.

@rnfinnegan, it seems that there shouldn't be any problem simply replacing np.alen() with len() here?

rnfinnegan commented 1 year ago

Yes, should be fine!

pchlap commented 1 year ago

This should be resolved in v0.6.0