search

pyplati / platipy

Processing Library and Analysis Toolkit for Medical Imaging in Python
https://pyplati.github.io/platipy/
Apache License 2.0
105 stars 24 forks source link

Separate out backend requirements #88

Closed pchlap closed 2 years ago

pchlap commented 2 years ago

@rnfinnegan I have separated out the requirements used for backend stuff only from the key requirements needed to use the main library functionality. In addition I have set the required versions to need a minimum of that version, rather than exactly that version. I think we should ensure that we give the users some flexibility here since they may be importing platipy into their library. Now that we have CI tests running on github we will be alerted if/when something breaks.

What do you think?

pchlap commented 2 years ago

@rnfinnegan I have separated out the requirements used for backend stuff only from the key requirements needed to use the main library functionality. In addition I have set the required versions to need a minimum of that version, rather than exactly that version. I think we should ensure that we give the users some flexibility here since they may be importing platipy into their library. Now that we have CI tests running on github we will be alerted if/when something breaks.

What do you think?

So the tests are failing because a newer version of skimage (if I remember correctly) render the mask slightly differently... Also a newer version of matplotlib is missing something used for animations...

This is a problem, because it would be good to support a range of library versions, making it more compatible for those integrating this into other libraries. This will required some more thought. Let's discuss it when we next catch up.

Phil

pchlap commented 2 years ago

Hi @rnfinnegan so by setting a max version on a couple of those libraries the tests are passing. Happy to merge this one?