search

pypr / pysph

A framework for Smoothed Particle Hydrodynamics in Python
http://pysph.readthedocs.io
Other
454 stars 138 forks source link

cull_factor is not initialized in code #352

Closed TermeHansen closed 2 years ago

TermeHansen commented 2 years ago

cull_factor is not initialized in all cases here

https://github.com/pypr/pysph/blob/bc5c793a82cb4a1f57a7602aea1be85d5e4cc87f/pysph/tools/ipy_viewer.py#L242

and make code crash if not set when reaching this line https://github.com/pypr/pysph/blob/bc5c793a82cb4a1f57a7602aea1be85d5e4cc87f/pysph/tools/ipy_viewer.py#L372

prabhuramachandran commented 2 years ago

Thanks, I fixed this.