pyproj4 / pyproj

Python interface to PROJ (cartographic projections and coordinate transformations library)
https://pyproj4.github.io/pyproj
MIT License
1.04k stars 210 forks source link

BUG: Support azimuthal_equidistant coordinate operation to CF #1380

Closed snowman2 closed 6 months ago

snowman2 commented 6 months ago

Related: https://github.com/OSGeo/PROJ/pull/3988

_________________________ test_azimuthal_equidistant __________________________

    def test_azimuthal_equidistant():
        crs = CRS("ESRI:54032")
        expected_cf = {
            "semi_major_axis": 6378137.0,
            "semi_minor_axis": crs.ellipsoid.semi_minor_metre,
            "inverse_flattening": crs.ellipsoid.inverse_flattening,
            "reference_ellipsoid_name": "WGS 84",
            "longitude_of_prime_meridian": 0.0,
            "prime_meridian_name": "Greenwich",
            "geographic_crs_name": "WGS 84",
            "horizontal_datum_name": "World Geodetic System 1984",
            "projected_crs_name": "World_Azimuthal_Equidistant",
            "grid_mapping_name": "azimuthal_equidistant",
            "latitude_of_projection_origin": 0.0,
            "longitude_of_projection_origin": 0.0,
            "false_easting": 0.0,
            "false_northing": 0.0,
        }
        cf_dict = crs.to_cf()
        assert cf_dict.pop("crs_wkt").startswith("PROJCRS[")
>       assert cf_dict == expected_cf
E       AssertionError: assert {} == {'false_easti...distant', ...}
E         
E         Right contains 14 more items:
E         {'false_easting': 0.0,
E          'false_northing': 0.0,
E          'geographic_crs_name': 'WGS 84',
E          'grid_mapping_name': 'azimuthal_equidistant',
E          'horizontal_datum_name': 'World Geodetic System 1984',
E          'inverse_flattening': 298.257223563,
E          'latitude_of_projection_origin': 0.0,
E          'longitude_of_prime_meridian': 0.0,
E          'longitude_of_projection_origin': 0.0,
E          'prime_meridian_name': 'Greenwich',
E          'projected_crs_name': 'World_Azimuthal_Equidistant',
E          'reference_ellipsoid_name': 'WGS 84',
E          'semi_major_axis': 6378137.0,
E          'semi_minor_axis': 6356752.314245179}
E         
E         Full diff:
E         + {}
E         - {
E         -     'false_easting': 0.0,
E         -     'false_northing': 0.0,
E         -     'geographic_crs_name': 'WGS 84',
E         -     'grid_mapping_name': 'azimuthal_equidistant',
E         -     'horizontal_datum_name': 'World Geodetic System 1984',
E         -     'inverse_flattening': 298.257223563,
E         -     'latitude_of_projection_origin': 0.0,
E         -     'longitude_of_prime_meridian': 0.0,
E         -     'longitude_of_projection_origin': 0.0,
E         -     'prime_meridian_name': 'Greenwich',
E         -     'projected_crs_name': 'World_Azimuthal_Equidistant',
E         -     'reference_ellipsoid_name': 'WGS 84',
E         -     'semi_major_axis': 6378137.0,
E         -     'semi_minor_axis': 6356752.314245179,
E         - }
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (43479b4) 96.40% compared to head (78147e2) 96.56%. Report is 5 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1380 +/- ## ========================================== + Coverage 96.40% 96.56% +0.16% ========================================== Files 20 20 Lines 1810 1807 -3 ========================================== Hits 1745 1745 + Misses 65 62 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.