Add query_geodetic_crs_from_datum

pyproj4 / pyproj

Python interface to PROJ (cartographic projections and coordinate transformations library)

https://pyproj4.github.io/pyproj

MIT License

1.04k stars 210 forks source link

Add query_geodetic_crs_from_datum #1390

Open jjimenezshaw opened 5 months ago

jjimenezshaw commented 5 months ago

Adds new API to PROJ. database.query_geodetic_crs_from_datum

[x] Closes #1389
[x] Tests added
[x] Fully documented, including history.rst for all changes and api/*.rst for new API

snowman2 commented 4 months ago

I tried to re-produce the error and couldn't with https://github.com/pyproj4/pyproj/compare/main...snowman2:pyproj:docker .

To debug, I suggest modifying the CI tests to specifically run the test that fails and trying these configurations:

set PROJ_DEBUG environment variable to 3
add -vv flag to tests
Install gdb and run gdb -ex=r --args /venv/bin/python -B -m pytest test/test_database.py

snowman2 commented 4 months ago

Also, it may not hurt to rebase this PR against the latest version.

jjimenezshaw commented 4 months ago

Also, it may not hurt to rebase this PR against the latest version.

I did rebase (after some problems), but the tests are not running. Is anything broken in the gh actions?

snowman2 commented 4 months ago

I see this error:

The workflow is not valid. .github/workflows/tests.yaml (Line: 127, Col: 17): Unexpected value ''

snowman2 commented 1 month ago

I was able to re-produce this with PROJ 9.3 (both docker & conda envs) and I did not encounter any errors with PROJ 9.4 on the docker image (https://github.com/pyproj4/pyproj/pull/1390#issuecomment-2065691985):

test/test_database.py 
Thread 1 "python" received signal SIGSEGV, Segmentation fault.
0x000075ff9a5b3079 in proj_list_get_count () from /lib/x86_64-linux-gnu/libproj.so.25

If logic is added in the function to not allow running in PROJ 9.3, I would be okay with adding this in.