pypsa-meets-earth / earth-osm

Export infrastructure data from OpenStreetMap using Python
https://pypsa-meets-earth.github.io/earth-osm/
MIT License
23 stars 12 forks source link

Add output directory option, to differentiate from the data directory that stores all intermediate files #45

Closed davide-f closed 1 year ago

davide-f commented 1 year ago

What does this PR do?

Fixes Issue #40

This PR adds the option to disentangle the output directory from the data directory. This enables to optionally specifying where the output files are stored, while keeping the data storage in another folder.

Type of Change

Checklist

All Done

codecov-commenter commented 1 year ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (861b4a4) 59.23% compared to head (e6e95a0) 59.30%.

Files Patch % Lines
earth_osm/eo.py 33.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #45 +/- ## ========================================== + Coverage 59.23% 59.30% +0.07% ========================================== Files 14 14 Lines 807 806 -1 ========================================== Hits 478 478 + Misses 329 328 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mnm-matin commented 1 year ago

These commits seem to also be in the buildings pr #46. To make it really simple I will just close this one.... unless I'm missing something.

davide-f commented 1 year ago

These commits seem to also be in the buildings pr #46. To make it really simple I will just close this one.... unless I'm missing something.

Np, the other PR is on top of this one, as you wish ;)