pypsa-meets-earth / pypsa-distribution

GNU General Public License v3.0
10 stars 8 forks source link

Add an option to disable subworkflow #36

Closed ekatef closed 6 months ago

ekatef commented 6 months ago

Closes #35, #20 and (hopefully) #32

Changes proposed in this Pull Request

Copy-pasted changes from PyPSA-Earth-Sec intended to add an option for switching-off the sub-workflows replacing them by a direct path definitions.

Tested on mac, seems to work properly and make life much easier. @davide-f thanks a lot for the proposed solution!

Checklist

ekatef commented 6 months ago

As a comment: for some reason, Snakemake linter is not happy with the changes complaining about missed keyword at the function definition for pypsaearth and usage for create_country_list. (So the commits have been possible only with --no-verify. Sorry for that!) However, both points seem to be perfectly valid approaches for Snakemake, as follows from the examples in Advanced Usage, so I'd rather say that the linter is not perfectly correct.

davide-f commented 6 months ago

That is weird, agree. Let's merge anyway :D

ekatef commented 6 months ago

That is weird, agree. Let's merge anyway :D

Thanks a lot for the idea of the fix and for merging!! Great to have the workflow running 🛫