pypsa-meets-earth / pypsa-earth-sec

GNU General Public License v3.0
20 stars 18 forks source link

Add minor features #170

Closed energyLS closed 1 year ago

energyLS commented 1 year ago

Changes proposed in this Pull Request

Checklist

energyLS commented 1 year ago

@Hazem-IEG I have opened up a PR with your changes and reviewed them. I have some minor comments but nothing critical I guess. One important thing though: I think you have incorporated many changes in config.yaml (e.g. h2export, etc,...) but this file is in gitignore. Could you copy the changes you have made in config.yaml to config.default.yaml and push config.default.yaml? Then I can proceed in getting the CI running. Thanks :)

energyLS commented 1 year ago

@Hazem-IEG I have made a couple of updates in the config.pypsa-earth.yaml and config.test1.yaml and tested it. Now it looks all good and runs on my local machine, I expect the CI to run as well. Once it does, could you please add an "Approving review"? -> Just approve it, could be done in seconds. Since I opened up the PR, my review doesn't count and the merge is blocked.

energyLS commented 1 year ago

@Hazem-IEG I have fixed it :) Now it is all ready to merge, I just need your approving review. Thanks!