Closed energyLS closed 1 year ago
@Hazem-IEG I have opened up a PR with your changes and reviewed them. I have some minor comments but nothing critical I guess.
One important thing though: I think you have incorporated many changes in config.yaml
(e.g. h2export, etc,...) but this file is in gitignore. Could you copy the changes you have made in config.yaml
to config.default.yaml
and push config.default.yaml
? Then I can proceed in getting the CI running. Thanks :)
@Hazem-IEG I have made a couple of updates in the config.pypsa-earth.yaml
and config.test1.yaml
and tested it. Now it looks all good and runs on my local machine, I expect the CI to run as well. Once it does, could you please add an "Approving review"? -> Just approve it, could be done in seconds. Since I opened up the PR, my review doesn't count and the merge is blocked.
@Hazem-IEG I have fixed it :) Now it is all ready to merge, I just need your approving review. Thanks!
Changes proposed in this Pull Request
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.