Closed hazemakhalek closed 10 months ago
I have the following comments:
# Keep only airports that are of type medium and large
# df = df.loc[df["type"].isin(["large_airport", "medium_airport"])]
Originally, the code keeps only medium and large airports and make the weighting like this (Please note that the last line must be equal to 2 and not 3:
# Keep only airports that are of type medium and large
df = df.loc[df["type"].isin(["large_airport", "medium_airport"])]
df.insert(2, "airport_size_nr", 1)
df.loc[df["type"].isin(["medium_airport"]), "airport_size_nr"] = 1
df.loc[df["type"].isin(["large_airport"]), "airport_size_nr"] = 2
df.insert(2, "airport_size_nr", 1)
df.loc[df["type"].isin(["medium_airport"]), "airport_size_nr"] = 1
df.loc[df["type"].isin(["large_airport"]), "airport_size_nr"] = 3
I suggest, that we keep only medium and large airports, as we originally did.
3. pt the following snippet in the script because we have to deal with these types of airports for the weighting and remove the colsed ones: ['small_airport', 'heliport', 'seaplane_base', 'medium_airport', 'large_airport', 'closed'].
I did not intend to keep the small one, that was commented out by mistake. I changed the sizing factor however to 3. Judging by a few checks in 3 countries, the large airports are usually much larger than the medium ones. I can set that as a config parameter to change accordingly
Closes # (if applicable).
Changes proposed in this Pull Request
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.