pypsa-meets-earth / pypsa-earth-sec

GNU General Public License v3.0
19 stars 16 forks source link

fix: write nan values when sector data is not given #272

Closed doneachh closed 4 months ago

doneachh commented 5 months ago

Closes # (if applicable).

Changes proposed in this Pull Request

When no sector data is given for a country, we write nan values into base_energy_totals.csv instead of ignoring it.

Checklist

doneachh commented 5 months ago

@energyLS i deleted a line in prepare_energy_totals, which dropped all lines with nan values as well to keep the keys. But in the next line na values get replaced by 0. Considering whether thats ok or to delete the line with replacing na by 0s as well. What do you think? :)

energyLS commented 5 months ago

@energyLS i deleted a line in prepare_energy_totals, which dropped all lines with nan values as well to keep the keys. But in the next line na values get replaced by 0. Considering whether thats ok or to delete the line with replacing na by 0s as well. What do you think? :)

@doneachh so basically we get zeros everywhere where you have introduced nans?

doneachh commented 5 months ago

@energyLS i deleted a line in prepare_energy_totals, which dropped all lines with nan values as well to keep the keys. But in the next line na values get replaced by 0. Considering whether thats ok or to delete the line with replacing na by 0s as well. What do you think? :)

@doneachh so basically we get zeros everywhere where you have introduced nans?

Yes