Closed Eddy-JV closed 2 months ago
Great @Eddy-JV :D I don't go into the functionality as I know you discussed with hazem and tested.
I dropped few comments for possibly improving the code, but I'd be eager to hear your feedback.
Hi @davide-f , sorry for the late reply. I have updated the PR including your very helpful comments. Thanks for taking the time to check it.
I guess now, the problem faced by @doneachh is solved. The problem was that some countries do not have any existing gas infra and this resulted in empty dataframes as well as its corresponding error.
But now the solution is: For countries/bus_regions that do not have existing gas infra, New H2 pipelines following electrical transmission lines is used.
Please check the solution if you have some time and give me a feedback. This way we can already merge the PR.
@davide-f I'd like to merge this, please let me know if you have any final comments
Closes # (if applicable).
Changes proposed in this Pull Request
The user now has now the option to choose the following in the
config.yaml
file:Greenfield:
["sector"]["hydrogen"]["network_routes"]
: "greenfield"["sector"]["hydrogen"]["gas_network_repurposing"]
: falseOnly New H2 pipelines following gas network:
["sector"]["hydrogen"]["network_routes"]
: "gas"["sector"]["hydrogen"]["gas_network_repurposing"]
: falseNew H2 pipelines following gas network + Repurposing:
["sector"]["hydrogen"]["network_routes"]
: "gas"["sector"]["hydrogen"]["gas_network_repurposing"]
: trueNew H2 pipelines following electrical transmission lines + Repurposing:
["sector"]["hydrogen"]["network_routes"]
: "greenfield"["sector"]["hydrogen"]["gas_network_repurposing"]
: trueChecklist
envs/environment.yaml
andenvs/environment.docs.yaml
.config.default.yaml
,config.tutorial.yaml
, andtest/config.test1.yaml
.doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.