Closed hazemakhalek closed 1 month ago
@hazemakhalek thanks for pushing this forward! :) I also have a proposal for a redesign I have done a while ago here: https://github.com/pypsa-meets-earth/pypsa-earth-sec/tree/mar_paper, in particular https://github.com/pypsa-meets-earth/pypsa-earth-sec/commit/0431ec0b9a515d3ebc8af5a9305415eb273a5ada. We should align these approaches if possible.
@hazemakhalek thanks for pushing this forward! :) I also have a proposal for a redesign I have done a while ago here: https://github.com/pypsa-meets-earth/pypsa-earth-sec/tree/mar_paper, in particular 0431ec0. We should align these approaches if possible.
Hey Leon, I think we can easily adapt it to include your additions. Do you know already when will you be back?
@hazemakhalek back now, happy to chat about it :)
@hazemakhalek back now, happy to chat about it :)
The PR is already really big and the review has been going for quite some time now. I think it makes sense to merge it and then review and merge the changes to temporal matching you implemented in a separate PR. What do you think?
It's fine from my side. WE can merge. But I guess you have to resolve the merge issue now due to the merge of africa's PR yesterday. I am happy to do it together if necessary.
Changes proposed in this Pull Request
This PR redesings the H2 policy features already existing and adds a new dimension to it. In this PR, one can separate between the different H2 colors, Green/Yellow based on the temporal matching applied, Pink coming from nuclear plants and Blue from SMR with CC.
Checklist
envs/environment.yaml
andenvs/environment.docs.yaml
.