pypsa-meets-earth / pypsa-earth-sec

GNU General Public License v3.0

18 stars 16 forks source link

fix MissingOutputException #324

Open doneachh opened 1 month ago

doneachh commented 1 month ago

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

[ ] I tested my contribution locally and it seems to work fine.
[ ] Code and workflow changes are sufficiently documented.
[ ] Newly introduced dependencies are added to envs/environment.yaml and envs/environment.docs.yaml.
[ ] Changes in configuration options are added in all of config.default.yaml, config.tutorial.yaml, and test/config.test1.yaml.
[ ] Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
[ ] A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

doneachh commented 1 month ago

Hi @davide-f & @energyLS , we are running into a MissingOutputException in prepare_gas_network when not using custom_data and !(len(pipelines.loc[pipelines.amount_states_passed >= 2]) > 0) as we dont create the pngs snakemake.output.gas_network_fig_1 and snakemake.output.gas_network_fig_2 there. Implemented a workaround to save empty pngs, when falling in this case. Do you have an idea for a better solution or can we merge it like this?

davide-f commented 1 week ago

Can we close this then?

doneachh commented 1 week ago

Can we close this then?

@davide-f Yes, but we should add a new issue for the plotting rule :)

davide-f commented 1 week ago

Absolutely agree, feel free to do that:)

doneachh commented 1 week ago

@energyLS as discussed in PyPSA-Earth-Sec Meeting --> workaround until plotting is an extra rule

energyLS commented 4 days ago

@doneachh it looks like the Missing Output Exception comes from snakemake? Or can you elaborate what the issue here is? If the issue comes from snakemake, then we should just remove the output defined by the snakefile? Also, can you link here the new issue you have created which refers to a proper plotting rule?