pypsa-meets-earth / pypsa-earth-sec

GNU General Public License v3.0
18 stars 16 forks source link

Linopy Integration #351

Open GbotemiB opened 6 days ago

GbotemiB commented 6 days ago

Closes # (if applicable).

Changes proposed in this Pull Request

Integrate linopy following https://github.com/PyPSA/pypsa-eur/pull/625 and https://github.com/pypsa-meets-earth/pypsa-earth/pull/796

Checklist

ekatef commented 3 days ago

Hello @GbotemiB!

Thanks a lot for opening the PR! Currently, CI is failing, and it looks like the reason is the recent environment troubles we experienced in PyPSA-Earth. Those troubles have been fixed recently with this PR and merged into Linopy PR in PyPSA-Earth. Could you please change the update the commit on which your PR relays? I think, this one should work fine.

GbotemiB commented 3 days ago

Hi @ekatef,

Thanks for looking into this. I will review the changes and revert.

ekatef commented 3 days ago

Hi @ekatef,

Thanks for looking into this. I will review the changes and revert.

Hey @GbotemiB, no worries and no need to revert! 🙂 All good, and we just need to include the recent changes form PyPSA-Earth upstream.

ekatef commented 3 days ago

Thanks a lot @GbotemiB! The update has worked 🎉 CI is failing currently but the reason is that some remote source is unavailable (urllib.error.HTTPError: HTTP Error 503: Service Unavailable).

The PR itself looks great! Is it ready for review?

GbotemiB commented 3 days ago

@ekatef, the PR is ready for review. I didn't mark it for review because the Linopy PR in pypsa-earth is still in draft.

I have investigated the error in the CI. It relates to prepare_transport_data_input:download_number_of_vehicles.py which is supposed to access this link here, but at the moment the site is currently not reachable. This should be the reason for the error.