pypsa-meets-earth / pypsa-earth

PyPSA-Earth: A flexible Python-based open optimisation model to study energy system futures around the world.
https://pypsa-earth.readthedocs.io/en/latest/
207 stars 167 forks source link

Quick fix for to adapt base_network for changes in voltage rebase #1008

Closed ekatef closed 2 months ago

ekatef commented 2 months ago

Needed to make base_network functional for networks with DC lines.

Changes proposed in this Pull Request

Adapt a workflow to the networks with DC lines after changes introduced by #999 and #978.

Checklist

ekatef commented 2 months ago

@davide-f @pz-max by any chance, could you have time to review this? 🙏🏽

My feeling is that it's a rather urgent fix, as due currently countries with DC lines are not functional, unless force_ac: true is applied.

ekatef commented 2 months ago

Thanks @ekatef ! Great catch! It may be interesting to add a minor bug fix into release note, what do you think? Feel free to merge autonomously with any comment in the release not or without

Thanks a lot @davide-f! Yeah, the release notes actually needed some update :) Then I'd merge it, once CI would be happy.