finozzifa commented 2 months ago

Closes # (if applicable).

Changes proposed in this Pull Request

[ x] I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
[x ] I tested my contribution locally and it seems to work fine.
[ ] Code and workflow changes are sufficiently documented.
[ ] Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
[ ] Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
[ ] Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
[ ] Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
[x ] A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

ekatef commented 2 months ago

Hello @finozzifa!

Thanks for the contribution :D Have added a little comment which relates to making the release note look nice.

Otherwise, looks good for me :)

finozzifa commented 2 months ago

Hi @ekatef, I performed the changes you requested. I hope I got your message right? if not, let me know :)

ekatef commented 2 months ago

Hi @ekatef, I performed the changes you requested. I hope I got your message right? if not, let me know :)

Perfect, thanks a lot for the changes!!

Let's wait until CI will run. After that, ready to be merged I think, unless @davide-f has any additional comments 🙂

ekatef commented 2 months ago

Merged :) @finozzifa thanks a lot for the fix and welcome into the contributors list!