Issue 687 pandas deprecations

[finozzifa]

Closes # (if applicable).

Issue #687

Changes proposed in this Pull Request

The changes are listed in the comment https://github.com/pypsa-meets-earth/pypsa-earth/issues/687#issuecomment-2100447481

Checklist

• [x ] I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
• [x ] I tested my contribution locally and it seems to work fine.
• [ ] Code and workflow changes are sufficiently documented.
• [ ] Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
• [ ] Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
• [ ] Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
• [ ] Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
• [x ] A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

[finozzifa]

Hi all, The PR apparently solves just three out of the four deprecations listed in Issue #687. The one in build_osm_network remains unfortunately still outstanding. Sincere apologies!

EDIT on May 10th 2024: all deprecations have been addressed!

[ekatef]

Hi all, The PR apparently solves just three out of the four deprecations listed in Issue #687. The one in build_osm_network remains unfortunately still outstanding. Sincere apologies!

EDIT on May 10th 2024: all deprecations have been addressed!

Perfect, thanks a lot for addressing this issue!! The PR looks good for me, have only some doubts regarding this special case of empty lines dataframe. It would be great to test that it really works as expected.

As an additional comment, I see that the CI logs became now much cleaner, which is the fantastic news 💚 But it appears that CI is reporting another pandas deprecation issue (haven't seen it locally): lines.geometry.loc[i] = linemerge( /home/runner/work/pypsa-earth/pypsa-earth/.snakemake/scripts/tmprqe2v9pu.build_osm_network.py:178: FutureWarning: ChainedAssignmentError: behaviour will change in pandas 3.0!. Would you mind to look into it?

[finozzifa]

Hi all, I have found extra deprecations that I have resolved. However there are a couple I would like your opinion about.

You can find them listed in this comment.

[ekatef]

Thanks a lot for introducing the changes @finozzifa! In my opinion, the PR is ready for merge :)

@davide-f what is your feeling about that? :) May you have any further comments?

[ekatef]

Merged :D

Thanks a lot @finozzifa for the great contribution! 🎉 🎉 🎉 Thanks to your PR, we are now ready to the future pandas, which is awesome :)))

@davide-f thank you for the fantastic support 🙂