pypsa-meets-earth / pypsa-earth

PyPSA-Earth: A flexible Python-based open optimisation model to study energy system futures around the world.
https://pypsa-earth.readthedocs.io/en/latest/
225 stars 175 forks source link

Output files with objective function value #1033

Closed finozzifa closed 3 months ago

finozzifa commented 4 months ago

Closes # (if applicable).

The pull request provides the initial ingredient for resolving https://github.com/pypsa-meets-earth/pypsa-earth/issues/495

Changes proposed in this Pull Request

Add output files and output snippet for the objective function value

Checklist

finozzifa commented 4 months ago

The pull request does not propose an automatic check of the objective function value as part of the CI/CD, as it is not explicitly requested in #495.

finozzifa commented 4 months ago

Hey @davide-f , thanks!!!

please proceed with merging it when you have time

davide-f commented 4 months ago

Maybe I have been clear my apologies. Why are you proposing to save the results in a txt file?

I think it may be better to print them with logger.info. That will print the results into screen and save the result in the log file.

This will also allow the easy check of the obviective value during review. What do you think?

finozzifa commented 4 months ago

Hi @davide-f , sure I will restore the Snakefile and replace the outputs with a logger.info

davide-f commented 3 months ago

Great @finozzifa :D Many thanks! As CI passes, this is merged :)

davide-f commented 3 months ago

Great @finozzifa :D Merging :)