Closed davide-f closed 6 months ago
Ready to Review
Ready to Review
Hello @davide-f! Congratulations with finalising this work 😄 Can I help you with review?
Ready to Review
Hello @davide-f! Congratulations with finalising this work 😄 Can I help you with review?
That would be awesome! :D
Hello @davide-f! Thanks for tackling this issue 😄
I think, the code looks great. Have added a couple of rather minor comments. Along the way, an alternative approach has been found to build url address for WDPA files (I just have been trying to understand how do they form their cloud url with month-year...). That is a domain of UN environmental program http://wcmc.io/wdpa_current_release
which re-directs to the same cloud entry. Could it make sense to consider it, probably as an alternative url? What do you think?
I'm also thinking that probably we may post somewhere comparison between the old and the new natura.tiff
files and test which effect does the new natura.tiff
on simulation results. If you think it's worth, happy to create an issue on that. Although, that is obviously a completely different story.
Great work with updating the datakit! 😄
Merging
Closes # (if applicable).
Changes proposed in this Pull Request
This PR automatically supports the download of landcover data from original source. Note: the landcover informations are only needed in the creation of the natura tiff file. As such, they are not used by the standard user.
This PR cannot be merged as the tutorial will fail: there is the need to create a natura.tiff file for each tutorial and add it to the databundles. Moreover, a better disclaimer for the license is needed, although the link is provided in the license page
Checklist
envs/environment.yaml
anddoc/requirements.txt
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.