search

pypsa-meets-earth / pypsa-zm-data

0 stars 8 forks source link

I have added the Hydro Validation notebook for Zambia #8

Closed tacwebservices closed 1 year ago

asolavi commented 1 year ago

Hi @tacwebservices, thanks for this PR. I like all your changes: Adding the hydro validation notebook, the config file, and the instructions on how to run the validation. Great work!

Before merging, can you change the config file name to one more illustrative, please? The point is that, as we add several configs, config.yaml won't really tell us what's in there. A suggested name is config.zm-default.yaml, but feel free to use another one.

Ready to merge after this name change :) Awesome work!

asolavi commented 1 year ago

Thanks @tacwebservices. I think you changed the directory name as well to config.zm-default.yaml and the config file name to config.zm.yaml.

Can you please change the directory name back to configs and the config file to config.zm-default.yaml?

asolavi commented 1 year ago

Thanks @tacwebservices, merging now.