search

pypxe / PyPXE

Pure Python PXE (DHCP-(Proxy)/TFTP/HTTP/NBD) Server
MIT License
547 stars 125 forks source link

Incorrect terminology in dhcp.py? #121

Closed fpf3 closed 8 years ago

fpf3 commented 8 years ago

According to RFC 1533, option 53 carries the DHCP message type. On line 314, you check if the message the server receives has a value of "1" in this field, and if so, you print "Received DHCPOFFER." Isn't it actually a "DHCPDISCOVER" message that you have received?

Similarly, in lines 320 and 323 you call what the RFC says is a DHCPREQUEST a DHCPACK.

Is this just a typo, or am I reading something wrong?

psychomario commented 8 years ago

It looks like you're correct and all three instances should read Sending rather than Received. I'll do a quick fix to the development branch.

psychomario commented 8 years ago

Done in cafcc2dcdb97af2ea173bbd3b853c210caa807ab. Also opened #122 to get this in master, along with a handful of other items.

mmattioli commented 8 years ago

@psychomario, in the future, since this issue is technically not resolved since it's not in master, simply add something to the fixing commit's message such as "fixes " and then the issue will be automatically closed when that commit is pushed to master from whichever branch it originated