TFTP Service Improvements

pbertera commented 9 years ago

added transfer mode check
added configurable TFTP timeout and retransmissions (library only)
fixed a bug in connection dropping if timeout reached

psychomario commented 9 years ago

This looks generally good, I've added a few line comments on a few sections.

pbertera commented 9 years ago

With my last commit this patch should be completed.

psychomario commented 9 years ago

Looks good to me. @mmattioli Any comments?

mmattioli commented 9 years ago

@psychomario LGTM! :+1: @pbertera, just for your own future reference, create separate feature branches for your pulls because then they can be deleted after they're merged and you can create fresh new ones that are automatically based off of the newly updated main branch in the repo. It's more for your own organization than ours but good practice in general. I noticed you reused your development-logging branch for this pull, next time maybe use something along the lines of development-short-patch-name.

pypxe / PyPXE

TFTP Service Improvements #69