mmattioli commented 9 years ago

Proposal

Preliminary cleanup of all changes made to development before merging to master to complete release v1.6.

psychomario commented 9 years ago

[x] The following table items are missing from the README.md table of arguments.

|__`--no-ipxe`__|Disable iPXE ROM|`True`|
|__`--no-http`__|Disable built-in HTTP server|`True`|
|__`--no-dhcp`__|Disable built-in DHCP server|`True`|
|__`--tftp`__|Enable built-in TFTP server which is enabled by default|`True`|

[x] NBD table in the README.md file is broken, I believe a newline is missing after the heading
[x] Pull out SETTINGS from pypxe-server.py for example_cfg.json. SETTINGS contains the most up to date full list of values acceptable in the JSON config file.
[x] Rename example-leases.json to example_leases.json to match example_cfg.json
[x] The README.md table contains the now-removed short CLI options.

mmattioli commented 9 years ago

Can you elaborate?

psychomario commented 9 years ago

Apologies, I sent the message in a rush. I'll go back and edit.

mmattioli commented 9 years ago

@psychomario I think I got all of your points above

psychomario commented 9 years ago

Yeah, and the rest all looks good to me.

mmattioli commented 9 years ago

@psychomario, all good to merge? We can test development after this is merged.

psychomario commented 9 years ago

Looks good to me!

pypxe / PyPXE

Preliminary Cleanup #87

Proposal