Various Patches which Complete v1.6

[mmattioli]

Proposal

Various bug fixes, patches, and improvements which complete v1.6. This release fixes #85, fixes #83, fixes #82, fixes #80, fixes #79, and fixes #27.

Improvements

• Added support for NBD (network block device)
• Added debug mode negation via CLI options
• Removed short CLI options
• Added support for static DHCP lease assignments and DHCP whitelist
• Improved CLI argument groupings to help without output out --help in pypxe-server.py

  Bug Fixes

• Now able to enable/disable services via CLI when using a JSON configuration file
• DHCP options are now client-specific

[mmattioli]

@psychomario before we do any actual testing perhaps we should take care of any missing documentation for whatever patches/fixes we have here?

[psychomario]

@mmattioli Probably, I was just about to comment regarding this. So far I've noticed that debug negation is missing from --help and the README, I'm just about to go through the rest to find other missing sections.

[psychomario]

The following kwarg table items are missing from DOCUMENTATION.md:

• DHCP
  • whitelist
  • static_config

I believe that is it. Do you want me to write a section under Background for NBD and a similar table for the kwargs?

[mmattioli]

@psychomario yeah if you handle the NBD stuff I'll take care of the DHCP stuff

[psychomario]

I've got something written up in #91, accepting any criticism.

[psychomario]

Do you think --dhcp-fileserver and --dhcp-whitelist should be somehow separated from the rest of the --dhcp-* arguments, as they are the two that are available in both --dhcp and --dhcp-proxy modes?

[mmattioli]

Not really, if someone has an understanding of how DHCP works then they should have an understanding that these two options would inherently work in both modes.

[psychomario]

Fair enough.

[mmattioli]

@psychomario is this ready for testing or are we missing something? Pretty sure we should be ready to start testing but just wanted to check with you.

[psychomario]

I think we're ready for testing. I'll be able to test everything in the ~morning, although I'm not expecting to find anything as I've been testing as I've been going along.

[mmattioli]

Sounds good, let me know if you run into anything because once this is merged and we tag the new release I think we can take a break for a while lol

[psychomario]

Well that's all the long standing issues done, except for NFS, which I really ought to get motivated to continue as I have the summer off.

[psychomario]

I've done some testing, and my fixes are present in #92, there's also a query regarding log messages. Once that PR is resolved then I think we're ready to be merged.

[mmattioli]

@psychomario LGTM Ready to go?

[psychomario]

Other than the query in #92, I think so:

With the initial debug logging block, there are a lot of lines that duplicate the service name in the log format string and the actual log message. For example:

2015-05-12 17:30:51,190 [DEBUG] PyPXE.TFTP TFTP Server IP: 0.0.0.0
2015-05-12 17:30:51,190 [DEBUG] PyPXE.TFTP TFTP Server Port: 69
2015-05-12 17:30:51,190 [DEBUG] PyPXE.TFTP TFTP Network Boot Directory: .

Should we remove the second TFTP, as it is already present in the logging namespace?

[mmattioli]

@psychomario just fixed, good catch :+1: Ready?

[psychomario]

@mmattioli Thanks! I think we're ready now, yes.