Only Increment Wrap after Going Half-way Through

pypxe / PyPXE

Pure Python PXE (DHCP-(Proxy)/TFTP/HTTP/NBD) Server

MIT License

547 stars 125 forks source link

Only Increment Wrap after Going Half-way Through #97

Closed icb- closed 9 years ago

icb- commented 9 years ago

I realized last night that duplicate acks for block 0 would incorrectly increase the wrap count. This makes it only increment the wrap after having gone half way through the sequence space. I've tested this against the tftp client in Tiny Core, FreeBSD, iPXE, and pxelinux without problems.

This is a much smaller bug than psychomario/PyPXE#95 since it would only occur on duplicate acks of block 0.

mmattioli commented 9 years ago

@icb- can you adjust self.armwrap to self.arm_warp to conform with PEP8? Aside from that this looks good to merge.

@psychomario do you want to look it over briefly?

icb- commented 9 years ago

Changed to arm_wrap and squashed the commit in the PR

mmattioli commented 9 years ago

LGTM @psychomario do you want to just take a peek really quick?

psychomario commented 9 years ago

Apologies, I couldn't look last night. This looks ready to go to me.

mmattioli commented 9 years ago

@psychomario this isn't a critical fix so I think we can leave this in development until we push the next release.

psychomario commented 9 years ago

@mmattioli Sounds good to me