search

pypy / pypy.org

Sources for website at https://www.pypy.org
33 stars 11 forks source link

remove unused css and also 'visited' styling #25

Closed mattip closed 3 years ago

mattip commented 3 years ago

xref hpyproject/hpyproject.org#15, doint it here instead since there are more pages to preview the change

mattip commented 3 years ago

@jablonskidev this site uses the same css as hpyproject.org. Can you checkout the styling of a few pages in the preview and confirm it is better than the web site? Once is merged I will make a PR to hpyproject.org with these changes

antocuni commented 3 years ago

This is a screenshot of how it looks on my machine: image

I think that the purple "PyPy" title looks a bit ugly. What about making the links always blue, without distinguishing between visited and unvisited? I think this is the approach taked by e.g. github itself

cfbolz commented 3 years ago

Fwiw, I dislike the recent trend towards not showing a difference for visited links (but feel free to ignore me)

mattip commented 3 years ago

What about making the links always blue, without distinguishing between visited and unvisited?

Reading about links and accessibility that seems like it might be a good choice, as well as adding back "underline", which is removed by the base Nikola theme.css. Done in latest commit.

mattip commented 3 years ago

@cfbolz can you suggest a color for visited links that looks good with the theme (which tried to maintain some consistency with the logo's greens, so purple clashes) and meets some accessibility requirements for discrimination from the other colors?

mattip commented 3 years ago

I am going to put this in to move it forward, but am happy to change it in the future as well.