search

pypy / pypy

PyPy is a very fast and compliant implementation of the Python language.
https://pypy.org
Other
790 stars 38 forks source link

PyPy is missing attributes in "stat" module #4953

Closed Erotemic closed 2 weeks ago

Erotemic commented 2 weeks ago

Initial discussion is here: https://github.com/orgs/pypy/discussions/4952

The issue is that on windows the stat module should define:

but these are missing.

mattip commented 2 weeks ago

Added in 1f46a199917. If the issue is causing you problems, you can modify the local version of stat.py and add the constants like in the changeset.

Closing, thanks for the report. Please reopen if I missed something.

Erotemic commented 2 weeks ago

Will this be in a patch release of pypy 3.9? The issue is that the stdlib shutil.copytree itself is broken on win32 when these attributes are not present and the copied directory contains a symlink. I find it surprising that there isn't a test case for that, but it is somewhat specific. I'd prefer not to monkey patch the stats module if possible, as this is an issue with a library not a particular application.

mattip commented 2 weeks ago

There are nightly builds, they can be used in github CI via the nightly tag or can be downloaded from https://buildbot.pypy.org/nightly/