pyqrcode / pyqrcodeNG

Python 2 and 3 module to generate QR Codes
BSD 3-Clause "New" or "Revised" License
12 stars 6 forks source link

QRCode.terminal() should write to the terminal by default #7

Closed heuer closed 6 years ago

heuer commented 6 years ago

IMO it makes almost no sense that QRCode.terminal() returns a string. The string is in almost all cases printed anyway.

Changing the behaviour would break backward compatibility, though.

Options:

The latter may be cleaner since the user gets a warning and it allows to remove the module_color and background arguments which have a dubious use, too

heuer commented 6 years ago

Initial work in https://github.com/heuer/pyqrcode/commit/bd38ae469c89a9d32c0a708f3e7cce2dc608f8fc

heuer commented 6 years ago

Fixed with release 1.3.0